Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NS: misc updates #513

Merged
merged 4 commits into from
Dec 28, 2021
Merged

NS: misc updates #513

merged 4 commits into from
Dec 28, 2021

Conversation

staghouse
Copy link
Member

@staghouse staghouse commented Dec 22, 2021

  • Formatting updates
  • Changed property blocks "Attributes" to "Tags"
  • Refactored the tagger for the PropertyToggler
  • Refactored formatTime to be a helper script with testing

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #513 (48dd85c) into master (b3717c6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #513   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         6    +1     
  Lines           40        58   +18     
  Branches        16        19    +3     
=========================================
+ Hits            40        58   +18     
Impacted Files Coverage Δ
docs/.vuepress/src/scripts/formatTime.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3717c6...48dd85c. Read the comment docs.

@staghouse staghouse temporarily deployed to mtgjson-webs-ns-misc-up-ujyxnw December 22, 2021 19:21 Inactive
@staghouse staghouse temporarily deployed to mtgjson-webs-ns-misc-up-ujyxnw December 22, 2021 19:25 Inactive
@staghouse staghouse temporarily deployed to mtgjson-webs-ns-misc-up-ujyxnw December 28, 2021 17:08 Inactive
@staghouse staghouse merged commit 9786bb6 into master Dec 28, 2021
@staghouse staghouse deleted the NS_misc_updates branch December 28, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant