Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Refactor rowCount error to a warning #14887

Open
michelengelen opened this issue Oct 9, 2024 · 0 comments
Open

[data grid] Refactor rowCount error to a warning #14887

michelengelen opened this issue Oct 9, 2024 · 0 comments
Labels
component: data grid This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature

Comments

@michelengelen
Copy link
Member

michelengelen commented Oct 9, 2024

Is there a deeper reason for this error message or just to warn the developer @michelengelen?
We don't use server side fetching, but use filtering outside of the Datagrid. So, there's a subset of the total rows supplied to the grid in some occasions. We use rowCount to display the total number of rows in the footer.

Now we get an annoying error message. We know it doesn't have any "effect", but we need it for display reasons anyways. Unless there's an actual error, maybe warning would be more appropriate (and only in dev), otherwise, it's unnecessary code that gets bundled into production it seems?

This is a valid request IMO ... changing this to a warning also does not hurt as there isn't an actual error to be expected here.

Originally posted by @lauri865 in #12448 (comment)

Search keywords:

@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 9, 2024
@michelengelen michelengelen added component: data grid This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 9, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Needs refinement in MUI X Data Grid Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature
Projects
Status: 🆕 Needs refinement
Development

No branches or pull requests

1 participant