-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Log error if rowCount
is used with client-side pagination
#12448
Conversation
Deploy preview: https://deploy-preview-12448--material-ui-x.netlify.app/ Updated pages: |
Should we also add a runtime warning in dev mode?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
rowCount
proprowCount
prop
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com> Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
rowCount
proprowCount
is used with client-side pagination
@LukasTy the tests failing seem unrelated to this PR. Could you have a look since the ones failing are for
|
@michelengelen Could you first sync with master and see if it helps? 🤔 |
Is there a deeper reason for this error message or just to warn the developer @michelengelen? Now we get an annoying error message. We know it doesn't have any "effect", but we need it for display reasons anyways. Unless there's an actual error, maybe warning would be more appropriate (and only in dev), otherwise, it's unnecessary code that gets bundled into production it seems? |
mui#12448) Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com> Co-authored-by: Andrew Cherniavskyi <andrew@mui.com>
mui#12448) Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com> Co-authored-by: Andrew Cherniavskyi <andrew@mui.com>
Added a warning that the
rowCount
prop has no effect when usingpaginationMode = client
.fixes #7303