[code-infra] Make tests on React 18 part of pipeline

[LukasTy]

Implement decision discussed here: https://mui-org.slack.com/archives/C011VC970AW/p1741612073853199

Makes test run on React 18 on each pipeline run. This aligns the behavior with base-ui repo.

Note

test_static will be fixed with #16934.

[mui-bot]

Deploy preview: https://deploy-preview-16933--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against c8d9963

[JCQuintas]

Should we make the react 18 pipelines required?

[LukasTy]

Should we make the react 18 pipelines required?

Agreed. 👍
I take it the configuration is on GH settings that almost no one has access to? 😃

[JCQuintas]

Should we make the react 18 pipelines required?

Agreed. 👍 I take it the configuration is on GH settings that almost no one has access to? 😃

yes

[LukasTy]

Should we make the react 18 pipelines required?

@DanailH, maybe you have access to adjust these settings? 🤔

[github-actions]

Cherry-pick PRs will be created targeting branches: v7.x

[oliviertassinari]

👍 I have almost never seen CI checks that only runs on the default branch work in practice.

I guess covering React v17 is needed but would be overkill, so not pragmatic, makes sense to skip it:

https://tools-public.mui.com/prod/pages/npmVersion?package=react-dom.

---

I take it the configuration is on GH settings that almost no one has access to?

This is configured in https://github.com/mui/mui-x/settings/rules, per https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-repositories/managing-repository-roles/repository-roles-for-an-organization

we need Admin. So yeah, only 5 people can do this: https://github.com/orgs/mui/teams/company-admin/members.

[oliviertassinari]

@LukasTy It seems that this creates a problem with Argos CI. We generate screenshots for React 18 and React 19, for example https://app.argos-ci.com/mui/mui-x/builds/33556/147652868 and https://app.argos-ci.com/mui/mui-x/builds/33555/147652013 but it only reports the latest build in the PR #17104.

Now, if the CSS is wrong, React 19 tests should catch it for React 18 too. If the behavior changes for React 18, unit tests should catch. So I struggle to see a case where those React 18 visual regression tests adds coverage. Maybe we can simply remove React 18 screenshots? Otherwise, I imagine that the solution is https://argos-ci.com/docs/build-splitting#practical-application.

[LukasTy]

@oliviertassinari Thanks for noting it. 👍
Indeed, there is little to no need to always run regressions on React 18 as well.
I've raised a PR to remove that step: #17108.

However, I've kept the regressions step when the additional_tests pipeline is manually triggered. 😉

mui-x/.circleci/config.yml

Lines 390 to 393 in a04c849

	- test_regressions:
	<<: *default-context
	name: test_regressions_additional
	react-version: << pipeline.parameters.with-react-version >>