[docs] Fix Data Grid advanced list view demo #17064
Merged
+25
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for adding a type label to the PR! 👍 |
KenanYusuf
added
bug 🐛
|
Deploy preview: https://deploy-preview-17064--material-ui-x.netlify.app/ |
KenanYusuf
commented
Mar 21, 2025
| // This is used only for the example - renders the drawer inside the container | ||
| const containerRef = React.useRef(null); | ||
| const container = () => containerRef.current; |
There was a problem hiding this comment.
This was returning null when the drawer opened, meaning it did not have a container to render to.
arminmeh
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
windowprop that gets passed to iframe demos instead of a ref on the container element.Fixes #17056
Before
https://next.mui.com/x/react-data-grid/list-view/#advanced-usage
list-view.mp4
After
https://deploy-preview-17064--material-ui-x.netlify.app/x/react-data-grid/list-view/#advanced-usage
Screen.Recording.2025-03-21.at.09.14.23.mov