[fields] Extract the props of each field slot into a standalone hook for easier re-use #17114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
component: pickers
|
Thanks for adding a type label to the PR! 👍 |
flaviendelangle
commented
Mar 24, 2025
| event.preventDefault(); | ||
| return; | ||
| } | ||
| const handleRootKeyDown = useEventCallback((event: React.KeyboardEvent<HTMLDivElement>) => { |
There was a problem hiding this comment.
I'm keeping the props.onKeyDown?.(event) (and equivalents) here because on Base UI it's handled automatically so I can't have it in the shared code.
|
Deploy preview: https://deploy-preview-17114--material-ui-x.netlify.app/ |
flaviendelangle
force-pushed
the
extract-root-props
branch
from
2a228e9 to
a32ae3b
Compare
…mplementation can re-use
flaviendelangle
force-pushed
the
extract-root-props
branch
from
a32ae3b to
18a5d1a
Compare
flaviendelangle
changed the title
flaviendelangle
force-pushed
the
extract-root-props
branch
from
77ac57b to
8494df2
Compare
LukasTy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #14679
No behavior change