Fix #17320 and remove unexposed style settings that are not working well #17419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asattely
force-pushed
the
one-line-drum-trem-flip
branch
3 times, most recently
from
d435909 to
99d9df6
Compare
asattely
force-pushed
the
one-line-drum-trem-flip
branch
from
99d9df6 to
a01c8b0
Compare
asattely
changed the title
oktophonie
approved these changes
May 3, 2023
RomanPudashkin
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #17320
The logic for flipping notes that are part of two-note trems was being used for single note ones. That's been fixed!
In the process of testing this, it seems that there was a lot of unexpected and confusing directions being chosen when stem direction was set to auto on staves of different sizes. It turns out there was a style setting called
smallStaffStemDirectionwhich would make auto-direction chords on staves with a sufficiently low number of lines, new in 4.0. This style setting is now removed, which reverts back to MU3 behavior w/r/t stem directions on small staves, which was fine.