Add 44 to supported versions #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzur
reviewed
Jun 4, 2023
| @@ -6,14 +6,14 @@ class BaTimeExtension { | |||
| constructor() { | |||
| this.aggregateMenu = Panel.statusArea.quickSettings; | |||
| this.originalIndicator = this.aggregateMenu._system; | |||
| this.aggregateMenu._system = this.customIndicator = new BaTime.imports.power.Indicator(); | |||
| this.aggregateMenu._batteryTime = this.customIndicator = new BaTime.imports.power.Indicator(); | |||
There was a problem hiding this comment.
Is this change related to GNOME 44 support as well (i.e. the compatibility with the other extension) or is this unrelated to the GNOME version?
There was a problem hiding this comment.
It's to fix #14 which doesn't appear to be GNOME 44 specifically.
There was a problem hiding this comment.
Ok thanks! Would you please push the fix to a separate PR if it's unrelated to GNOME 44 support?
There was a problem hiding this comment.
Feels like extra work for little gain, but sure I have nothing going on right now.
There was a problem hiding this comment.
Thanks! It's just that I'd like to test the extension in GNOME 44 first but I can release the fix right away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to work with no changes required in GNOME Shell 44