Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GNOME 47 Support #23

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Add GNOME 47 Support #23

merged 1 commit into from
Dec 18, 2024

Conversation

8Dion8
Copy link

@8Dion8 8Dion8 commented Nov 11, 2024

Just added the version number and it works.

@Cub11k
Copy link

Cub11k commented Nov 11, 2024

I'm not sure if that's how you test the correctness of your PR?

@mzur
Copy link
Owner

mzur commented Nov 11, 2024

@8Dion8: Thanks!

@Cub11k: The more people confirm that it just works here, the more likely I am to merge the PR without testing it myself (which might take quite a while for me to find the time for).

@8Dion8
Copy link
Author

8Dion8 commented Nov 12, 2024

Sure, I'll add the details of my system in that case

System Details Report


Report details

  • Date generated: 2024-11-12 15:06:13

Hardware Information:

  • Hardware Model: Lenovo ThinkPad X1 Yoga 3rd
  • Memory: 16.0 GiB
  • Processor: Intel® Core™ i7-8650U × 8
  • Graphics: Intel® UHD Graphics 620 (KBL GT2)
  • Disk Capacity: 1.0 TB

Software Information:

  • Firmware Version: N25ET68W (1.54 )
  • OS Name: Fedora Linux 41 (Workstation Edition)
  • OS Build: (null)
  • OS Type: 64-bit
  • GNOME Version: 47
  • Windowing System: Wayland
  • Kernel Version: Linux 6.11.5-300.fc41.x86_64

@sovanyio
Copy link

Just modified my local copy and it is working after logging out/in.

@seekingmeanings
Copy link

This should be safe to be merged, as there are no relevant changes concerning the current code in 47

https://gjs.guide/extensions/upgrading/gnome-shell-47.html

As you can see, extension.js and metadata.json dont have any changes, prefs.js doesnt exist (yet) and methods for gnome-shell that have changed arent used in this extension.

lgtm.

Copy link

@seekingmeanings seekingmeanings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes to GNOME 47 dont affect current code

@balazsvajdics
Copy link

It works correctly for me as well!

@mzur
Copy link
Owner

mzur commented Dec 18, 2024

Ok thanks everyone!

@mzur mzur merged commit 9aade35 into mzur:master Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants