Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When editing the cell, data editor is created with old edited value (e.g. from different cell) then the value is updated to right value (second render) #230

Closed
LiborOl opened this issue Jul 21, 2020 · 0 comments · Fixed by #231
Assignees

Comments

@LiborOl
Copy link
Contributor

LiborOl commented Jul 21, 2020

It is caused by

 <DataCell ...
   editValue={this.state.editValue}

in DataSheet.

The data editor is rendered first time with value from previous edit and then the prop is updated with the correct value. It is not visible for the user, but if you use custom data editors, it may cause exceptions/warning because of different data types/structures.

I think, it is also source of the issue #218. All DataCells get the editValue.

@nadbm nadbm self-assigned this Jul 25, 2020
nadbm added a commit that referenced this issue Jul 25, 2020
@nadbm nadbm mentioned this issue Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants