Switch to Eclipse Temurin and add SDKMan for local dev #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
artur-ciocanu
force-pushed
the
use-temurin
branch
from
1b1e3b9 to
55f4043
Compare
|
Hello @scottf could you please review this tiny PR. Thank you 🙇♀️. |
|
@artur-ciocanu Can you please provide some explanation for the reason to make this change. Please explain why Temurin over Adopt and then why add the ".sdkmanrc" file? |
Response moved to main comment by @scottf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch build from AdoptOpenJDK to Eclipse Temurin. Eclipse Temurin is the successor to AdoptOpenJDK and the team behind AdoptOpenJDK recommends switching to Eclipse Temurin. Here are some relevant links: https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/, https://projects.eclipse.org/projects/adoptium.
.sdkmanrc- this file is used by SDKMan to switch between different Java versions. This is especially useful when you are working on different repositories and each repository uses a different Java version. SDKMan will use.sdkmanrcto switch to the right Java version and setJAVA_HOMEto the right path. Here is the official SDKMan docs: https://sdkman.io/jdks.