Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EX7-Additional Ellipse Azimuthの計算間違い #13

Closed
arms22 opened this issue Dec 5, 2024 · 3 comments
Closed

EX7-Additional Ellipse Azimuthの計算間違い #13

arms22 opened this issue Dec 5, 2024 · 3 comments
Assignees
@nbtk
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@arms22
Copy link

arms22 commented Dec 5, 2024

EX7-Additional Ellipse Azimuthの計算が間違っているようです。

azarashi/azarashi/qzss_dcr_lib/decoder/qzss_dcx_decoder.py

Line 411 in ea521f8

self.ex7_ellipse_azimuth = -90 + 180 / 0x40 * camf.ex7

正しくは

self.ex7_ellipse_azimuth = -90 + 180 / 128 * camf.ex7

ではないでしょうか？
@nbtk nbtk self-assigned this Dec 5, 2024
@nbtk nbtk added the bug Something isn't working label Dec 5, 2024
nbtk added a commit that referenced this issue Dec 5, 2024
@nbtk
#13 の指摘を受けて修正
905f046
nbtk added a commit that referenced this issue Dec 5, 2024
@nbtk
#13 の指摘を受けて修正
760dada
@nbtk nbtk added the good first issue Good for newcomers label Dec 5, 2024
@nbtk
Copy link
Owner

nbtk commented Dec 6, 2024

報告ありがとうございます。
ご指摘いただいた箇所、間違っていました。
テストして週明けにリリース予定です。

@arms22
Copy link
Author

arms22 commented Dec 6, 2024

ご対応ありがとうございます！
デコード結果突き合わせて確認するのにめちゃくちゃ助かっています！

@nbtk
Copy link
Owner

nbtk commented Dec 9, 2024

役に立っているようならうれしいです！
こちらこそ、ありがとうございます。

直しました。
https://github.com/nbtk/azarashi/releases/tag/v0.11.0

@arms22 arms22 closed this as completed Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nbtk nbtk

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arms22 @nbtk