Challenge prep refactoring #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilblackdragon
requested review from
evgenykuzyakov and
maxzaver
as code owners
3 tasks
evgenykuzyakov
approved these changes
Oct 15, 2019
ilblackdragon
requested review from
SkidanovAlex
and removed request for
SkidanovAlex
SkidanovAlex
approved these changes
Oct 16, 2019
Kouprin
pushed a commit
that referenced
this pull request
Oct 17, 2019
* Added retry to send requests for chunk one parts and parts themself * Adding dropping chunks in cross_shard test * ... * Enough clutches to make it work. Mostly * Removing slow reads * Polishing * Fixing tests and build * Removing unnecessary signature checks, since they are more expensive now. * First pass of refactorings from #1372 * Refactor chunks * Continue refactoring * Remove CryptoHashView * Stop accepting parts after collected chunk. Test logger in chunk_management tests * Only persist chunks if chunk is new * Address the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for adding challenges, splitting the refactoring to easily test / add challenges into separate PR.