Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: do not pass deprecated groups argument to PropertyDescriber #2451

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Mar 6, 2025

Refs: #2450

Description

Avoids triggering deprecation notices. The groups are already coming from the models serializationContext, so there is no need to even pass them because serializationContext is already passed.

What type of PR is this? (check all applicable)

  • Bug Fix
  • Feature
  • Refactor
  • Deprecation
  • Breaking Change
  • Documentation Update
  • CI

Checklist

  • I have made corresponding changes to the documentation (docs/)
  • I have made corresponding changes to the changelog (CHANGELOG.md)

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.25%. Comparing base (1497977) to head (86a4bc4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2451      +/-   ##
==========================================
- Coverage   90.23%   89.25%   -0.98%     
==========================================
  Files          94       94              
  Lines        3081     3081              
==========================================
- Hits         2780     2750      -30     
- Misses        301      331      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DjordyKoert DjordyKoert merged commit 5283236 into nelmio:master Mar 7, 2025
26 of 27 checks passed
@DjordyKoert
Copy link
Collaborator

thank you! :)

@herndlm herndlm deleted the groups-deprecation branch March 7, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants