Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBFT: add dbft unit test #836

Closed
wants to merge 9 commits into from
Closed

DBFT: add dbft unit test #836

wants to merge 9 commits into from

Conversation

Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Oct 11, 2023

add the unit test for dbft

@Jim8y
Copy link
Contributor Author

Jim8y commented Oct 11, 2023

@igormcoelho Hey man, i tried my best to migrate this into N3, but there still a few accessible issues, i think you might delete them directly, so i will stop from here. Let me know when you need my further help.

@vncoelho
Copy link
Member

I will soon try to add the tests, thank you very much, @Liaojinghui.
Restore these tests is of great importance.

Jim8y and others added 3 commits October 11, 2023 22:09

Partially verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
vncoelho and others added 3 commits October 23, 2023 09:34

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
@shargon
Copy link
Member

shargon commented Nov 8, 2023

@Liaojinghui please give me rights in your branch to change some small things

@shargon
Copy link
Member

shargon commented Nov 8, 2023

@Liaojinghui ut fails

@Jim8y
Copy link
Contributor Author

Jim8y commented Nov 8, 2023

@shargon my bad, this one should be marked as draft, @vncoelho want to build the unit test for dbft, haven't complete

@Jim8y Jim8y marked this pull request as draft November 8, 2023 08:38
@Jim8y
Copy link
Contributor Author

Jim8y commented Nov 8, 2023

@shargon my bad, this one should be marked as draft, @vncoelho want to build the unit test for dbft, haven't complete, @vncoelho will do the rest

@vncoelho
Copy link
Member

vncoelho commented Nov 9, 2023

@shargon, if the idea is to move neo-modules back to neo core, I think I will not focus on this now.

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants