Add OnPayment in OracleContract #2094
Conversation
|
#2095 is better |
| [ContractMethod(0_00100000, CallFlags.None)] | ||
| private void OnPayment(ApplicationEngine engine, UInt160 from, BigInteger amount) | ||
| { | ||
| if (engine.CallingScriptHash != Hash) |
There was a problem hiding this comment.
So, it's like "Oracle" tokens? Maybe we need to fix GAS calls to go through CallFromNativeContract? Although it's Mint being called here...
There was a problem hiding this comment.
GAS.Mint cann't be called by contract, so we cann't call it through CallFromNativeContract.
| [ContractMethod(0_00100000, CallFlags.None)] | ||
| private void OnPayment(ApplicationEngine engine, UInt160 from, BigInteger amount) | ||
| { | ||
| if (engine.CallingScriptHash != GAS.Hash) |
There was a problem hiding this comment.
The calling scripthash couldn't be GAS.Hash.
There was a problem hiding this comment.
Change CallingScriptHash after call CallFromNativeContract?
There was a problem hiding this comment.
engine.CurrentContext.GetState<ExecutionContextState>().CallingScriptHash = GAS.Hash;There was a problem hiding this comment.
Or load a GAS context before call it
There was a problem hiding this comment.
Maybe we add a MintWithoutCallingOnPayment() method in GAS.
There was a problem hiding this comment.
Just remove PostTransfer in Mint and Burn method?
There was a problem hiding this comment.
But it breaks the context, a little....
There was a problem hiding this comment.
Just remove PostTransfer in Mint and Burn method?
But you need to fire the Transfer event.
Close #2093