Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use system ECDsa #2340

Merged
merged 4 commits into from
Feb 17, 2021
Merged

Use system ECDsa #2340

merged 4 commits into from
Feb 17, 2021

Conversation

erikzhang
Copy link
Member

No description provided.

@erikzhang
Copy link
Member Author

@neo-project/ngd-shanghai Can you test more os to see whether it works?

vncoelho
vncoelho approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked here as well, however, still Linux based versions.

@ProDog
Copy link
Contributor

ProDog commented Feb 16, 2021

@neo-project/ngd-shanghai Can you test more os to see whether it works?

OK. I'll test.

@ProDog
Copy link
Contributor

ProDog commented Feb 17, 2021

I have tested with multiple nodes on win10 and linux, it's working well.

@erikzhang
Copy link
Member Author

Did you test Ubuntu and CentOS?

@ProDog
Copy link
Contributor

ProDog commented Feb 17, 2021

Did you test Ubuntu and CentOS?

Yes, the linux nodes includes Ubuntu and CentOS.

@erikzhang erikzhang merged commit b11d7d2 into master Feb 17, 2021
@erikzhang erikzhang deleted the use-system-ecdsa branch February 17, 2021 04:32
@ixje ixje mentioned this pull request Jun 8, 2021
Closed
@vncoelho vncoelho mentioned this pull request May 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

@vncoelho vncoelho vncoelho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erikzhang @ProDog @shargon @vncoelho