Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated nuget release packages #3322

Closed

Conversation

cschuchardt88
Copy link
Member

Change Log

  • Add plugins to Release for nuget

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Jim8y Jim8y removed this from the v3.7.5 milestone Jun 11, 2024
Comment on lines +207 to +212
- name : Pack (ApplicationLogs)
if: steps.check_tag.outputs.statusCode == '404'
run: |
dotnet pack ./src/Plugins/ApplicationLogs \
--configuration Release \
--output ./out
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can easily be moved under matrix strategy in order to avoid code duplication between the Pack (*) steps and run them in parallel.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes i know. I will be fixing all these workflows.

@cschuchardt88
Copy link
Member Author

Refactor see PR #3338

@cschuchardt88 cschuchardt88 deleted the fix/nuget-packages branch June 24, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants