-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix
] StackItem.GetHashCode for CompoundType
#3549
[Fix
] StackItem.GetHashCode for CompoundType
#3549
Conversation
foreach (var item in SubItems) | ||
{ | ||
// This isn't prefect and leaves somethings unsolved. | ||
if (item is CompoundType cItem) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is such a cause here:
var map1 = new Map();
map1[1] = 2;
map1[3] = 4;
var map2 = new Map();
map2[3] = 4;
map2[1] = 2;
Assert.AreEqual(map1.GetHashCode(), map2.GetHashCode());
Assert.AreEqual
failed.
Because VM.Map
uses OrderedDictionary
internally, but OrderedDictionary
is not ordered.
it should be fixed or not ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be fixed in a new PR
Description
Close #3544
Type of change
How Has This Been Tested?
Checklist: