Add new vector index settings #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no strong preference on the wording currently, just jotted down some things we can iterated upon. |
parnmatt
force-pushed
the
5.23-index-settings
branch
from
af4b0ce to
7123cd5
Compare
neo-ionut
approved these changes
Jul 30, 2024
modules/ROOT/pages/indexes/semantic-indexes/vector-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/semantic-indexes/vector-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/semantic-indexes/vector-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/semantic-indexes/vector-indexes.adoc
Outdated
Show resolved
Hide resolved
* fix typo * clarify omitting dimensions * move vector provider difference note
rsill-neo4j
reviewed
Jul 31, 2024
modules/ROOT/pages/indexes/semantic-indexes/vector-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/semantic-indexes/vector-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/semantic-indexes/vector-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/semantic-indexes/vector-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/semantic-indexes/vector-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/semantic-indexes/vector-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/semantic-indexes/vector-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/semantic-indexes/vector-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/semantic-indexes/vector-indexes.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Richard Sill <156673635+rsill-neo4j@users.noreply.github.com>
There was a problem hiding this comment.
Thanks @parnmatt! I have some editorial suggestions, and a few areas where I didn't fully understand what was going on. Also, we need to add the 3 new settings to the Additions and Deprecations page (I can do this once we have clarified everything else, if you like).
modules/ROOT/pages/indexes/semantic-indexes/vector-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/semantic-indexes/vector-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/semantic-indexes/vector-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/semantic-indexes/vector-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/semantic-indexes/vector-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/semantic-indexes/vector-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/semantic-indexes/vector-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/semantic-indexes/vector-indexes.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/indexes/semantic-indexes/vector-indexes.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Jens Pryce-Åklundh <112686610+JPryce-Aklundh@users.noreply.github.com>
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have exposed quantization, and
MandefConstructionhyperparameters for the vector index.We have also allowed the similarity function to be defaulted to
'cosine', and for the dimensions to not need to be specified.