refactor: calculate address first before cond operation #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were doing the cond operation first on the PC offsets, then add the base PC address to form the final AST node. The problem with this, is that the base PC addresses and offsets are both immediate values in most instructions. So we can just calculate the final PC addresses first, then apply the cond operation. In a normal interpreter this won't matter, but for JIT or AOT implementation, this makes sure we can have simpler AST node to apply optimizations
doitian
approved these changes
May 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were doing the cond operation first on the PC offsets,
then add the base PC address to form the final AST node. The problem
with this, is that the base PC addresses and offsets are both
immediate values in most instructions. So we can just calculate the
final PC addresses first, then apply the cond operation. In a normal
interpreter this won't matter, but for JIT or AOT implementation, this
makes sure we can have simpler AST node to apply optimizations