-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use SQLite implement PeerStore to replace current MemoryPeerStore #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7aef7ba
to
dc70950
Compare
so we use both rocksdb and sqlite in ckb? |
quake
previously requested changes
Dec 26, 2018
Currently, SQLite is only used in peer_store component cause mostly operations in peer_store is scanning query, as a dependency SQLite is lightweight enough(~500 KB) so I think it worth to introduce it. |
quake
reviewed
Dec 26, 2018
25831b2
to
d162316
Compare
Benchmark result of SqlitePeerStore
|
d162316
to
5e6569d
Compare
04fa98f
to
6eb6b6f
Compare
quake
requested changes
Jan 3, 2019
6eb6b6f
to
6ecd2c9
Compare
quake
approved these changes
Jan 3, 2019
6ecd2c9
to
1318788
Compare
1318788
to
8763d34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.