-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(sync): Fix get ancestor performance issue #970
Merged
TheWaWaR
merged 5 commits into
nervosnetwork:develop
from
TheWaWaR:fix-get-ancestor-perf-issue
Jun 11, 2019
Merged
perf(sync): Fix get ancestor performance issue #970
TheWaWaR
merged 5 commits into
nervosnetwork:develop
from
TheWaWaR:fix-get-ancestor-perf-issue
Jun 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@quake is assigned as the chief reviewer |
doitian
reviewed
Jun 8, 2019
doitian
reviewed
Jun 8, 2019
driftluo
approved these changes
Jun 11, 2019
doitian
approved these changes
Jun 11, 2019
It's an important performance improvement, could you backport this PR to rc/v0.14.0? I think we need this PR in the next release. |
OK |
This was referenced Jun 14, 2019
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: The implementation and test is almost copy from bitcoin.