Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support native private class properties in model class visitor #3324

Merged

Conversation

rklos
Copy link
Contributor

@rklos rklos commented Feb 27, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: !3322

What is the new behavior?

Private properties of a class are omitted now, so they do not cause the SyntaxError.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@rklos
Copy link
Contributor Author

rklos commented Feb 27, 2025

Im not sure if those _CreateCatDto_privateProperty.set(this, void 0);'ish changes in transpiled fixtures are ok or not.
Besides that, the _OPENAPI_METADATA_FACTORY is free of private properties and now it works when used inside an application.

@kamilmysliwiec
Copy link
Member

LGTM 💪

@kamilmysliwiec kamilmysliwiec merged commit fb31842 into nestjs:master Feb 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants