Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve prompts for link command #502

Merged
merged 5 commits into from
Sep 9, 2019

Conversation

verythorough
Copy link
Contributor

Summary

Restores the site name search functionality removed in #335, along with some minor updates to copy and code. Partially addresses #496.

Test plan

Run the netlify link command and try all of the options in the prompt tree:

  • Use Git remote
  • Search by name
    • with a string of garbage text that you know won't match anything
    • with a unique site name that isn't also part of another site name
    • with a short string that you know will match multiple site names
    • with an empty input
    • from an account with no sites
  • Choose from a list of sites
    • from an account with multiple sites
    • from an account with no sites
  • Enter site ID
    • with a valid site ID
    • with an invalid site ID

Description for the changelog

  • Restore site name search functionality in link command prompts
  • Update link command prompt text for greater clarity and consistency
  • Refactor link command prompt code for consistency between prompts

Other impacts

This also changes the telemetry data collected for the kind field:

  • byName changed to refer to the "search by name" prompt again as it did in v2.11.23 and before
  • "Choose from list" prompt is now referred to as fromList

A picture of a cute animal (not mandatory but encouraged)

peeking hedgehog

Copy link
Contributor

@RaeesBhatti RaeesBhatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and everything seems to be working. Thanks @verythorough 👍🏽

@RaeesBhatti RaeesBhatti merged commit 41023fe into master Sep 9, 2019
@RaeesBhatti RaeesBhatti deleted the verythorough/improve-link-prompts branch September 9, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants