NETOBSERV-2006 Cover all new features in e2e tests #148
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
=======================================
Coverage 23.70% 23.70%
=======================================
Files 11 11
Lines 1333 1333
=======================================
Hits 316 316
Misses 1000 1000
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
jpinsonneau
force-pushed
the
2006
branch
2 times, most recently
from
3039e68 to
e6559ab
Compare
|
Rebased without changes |
|
Rebased again without changes |
|
FYI e2e is failing because of netobserv/netobserv-ebpf-agent#513 |
|
Rebased without changes |
|
|
/retest |
|
/ok-to-test |
|
New image: It will expire after two weeks. To use this build, update your commands using: USER=netobserv VERSION=f5bd1f9 make commands |
|
/label qe-approved |
| yamls = strings.Split(yamlStr, "---") | ||
| assert.Equal(t, 6, len(yamls)) | ||
|
|
||
| // check yaml contents |
There was a problem hiding this comment.
this is hard to maintain why not create a multi line yaml content string and u can compare against it ?
There was a problem hiding this comment.
could you please provide an example ?
There was a problem hiding this comment.
here is an example of constant yaml string
yaml := `
kind: Namespace
apiVersion: v1
metadata:
name: netobserv-cli
labels:
app: netobserv
pod-security.kubernetes.io/enforce: privileged
pod-security.kubernetes.io/audit: privileged
openshift.io/cluster-monitoring: "true"
`
| yamls = strings.Split(yamlStr, "---") | ||
| assert.Equal(t, 6, len(yamls)) | ||
|
|
||
| // check yaml contents |
| yamls = strings.Split(yamlStr, "---") | ||
| assert.Equal(t, 10, len(yamls)) | ||
|
|
||
| // check yaml contents |
Description
Add --yaml option to be able to test metrics command.
Also test flow & packet yaml output with filters
Dependencies
Based on #146, merge it first !
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.