Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update linter to avoid memory leak #206

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

jpinsonneau
Copy link
Contributor

I'm experiencing memory leaks using the old version of golangci-lint
Updating it fixes the issue

@jpinsonneau jpinsonneau requested a review from msherif1234 March 3, 2025 09:09
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.70%. Comparing base (615f554) to head (f28b684).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
+ Coverage   23.53%   23.70%   +0.17%     
==========================================
  Files          11       11              
  Lines        1330     1333       +3     
==========================================
+ Hits          313      316       +3     
  Misses       1000     1000              
  Partials       17       17              
Flag Coverage Δ
unittests 23.70% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link

openshift-ci bot commented Mar 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d7dff49 into netobserv:main Mar 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants