Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Spotless + Maven wrapper #246

Merged
merged 2 commits into from
Feb 15, 2025
Merged

Conversation

ccudennec-otto
Copy link
Contributor

@ccudennec-otto ccudennec-otto commented Feb 14, 2025

fixes #245

@UrielCh
Copy link
Contributor

UrielCh commented Feb 14, 2025

you can now commit the formatted code, to the github action will be happy.

@ccudennec-otto
Copy link
Contributor Author

you can now commit the formatted code, to the github action will be happy.

Done 🙂

I used "googleJavaFormat" in the default configuration which resulted in quite a lot of changes. Can you review the new formatting if that's good enough or if I should apply changes to the formatter configuration?

From my personal experience, the main benefit of having a code formatter is that you don't need to worry about the formatting anymore - even if the formatter sometimes might not 100% match the personal taste. Feel free to suggest some configuration changes to make the codestyle match your taste. 🙂 Compare the official documentation to get some ideas.

You can apply formatting changes by executing ./mvnw spotless:apply. Should this be mentioned in the README.md?

Cheers,

Christopher

@UrielCh
Copy link
Contributor

UrielCh commented Feb 15, 2025

I'm reading the codebase.

I'm surprise to see a forgotten import java.util.*; in my code base.
the tab are replaced by 2 space.
....

LGTM

@UrielCh UrielCh merged commit 5efc9ab into netplex:master Feb 15, 2025
6 checks passed
@ccudennec-otto ccudennec-otto deleted the spotless branch February 17, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven Wrapper and Code Formatting for easier contributions
3 participants