feat(application_settings): amp application settings to sync with the latest released/available features/functionalities in apm settings ui #1267
+193
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinay-newrelic
force-pushed
the
NR-343240
branch
from
0c0f1de to
7bd5f6d
Compare
vinay-newrelic
changed the title
pranav-new-relic
force-pushed
the
NR-343240
branch
2 times, most recently
from
11c1e53 to
27a1df4
Compare
pranav-new-relic
force-pushed
the
NR-343240
branch
from
27a1df4 to
114b5a6
Compare
…and reverted lint spelling changes
|
@vinay-newrelic all good here, except for one question (just adding it here for the record) - I think we'd discussed sometime that you intend to move the mutation to update application settings into a new/different package to avoid type conflicts, etc. Do you think that is still needed, or are we good with the current arrangement? I don't think there's anything incorrect, but would just like to double check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, this TF resource only supports a subset of the application settings available on the APM UI .
This PR concludes the changes required for
newrelic_application_settingsresource to add the missing set of configuration settings that are available on the UI