-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use window size to determine sidebar display, and unify behaviour for margin and dimmer #130
Conversation
Thanks so much for opening your first PR here! |
What is the relationship between NexT and SAP SE? In the agreement it asked me to give my rights to SAP SE, but I did not see anything mentioning relationship between NexT and SAP SE on NexT websites (So I definitely will not sign it for now.). I looked up https://cla-assistant.io/ and it seems to indicate projects should provide their own agreements. Was the one for NexT set up properly according to their guidelines? |
@@ -2,7 +2,7 @@ | |||
display: none; | |||
} | |||
|
|||
+mobile() { | |||
+tablet-mobile() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps unifying the behavior of the tablet and desktop is a better choice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think "Tablet" has enough space for both the article and sidebar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This problem is a bit tricky, because both 7.9-inch iPad mini and 12.9-inch iPad Pro are "Tablet"s.
I will merge this pull request and make adjustments based on subsequent user feedback. Thanks for your contribution.
Congrats on merging your first pull request here! 🎉 How awesome! |
PR Checklist
PR Type
What is the current behavior?
Screen size is used to determine whether sidebar is shown on page load, instead of window size.
This means those who have a narrow window on a wide screen will still have the sidebar shown.
This covers page content.
On "tablet" view (between "desktop" and "mobile"), the page content will be covered by the sidebar (

-margin
), but it is not dimmed (-dimmer
).Compare:
"desktop" view (
+margin -dimmer
):"mobile" view (
-margin +dimmer
):Issue resolved: N/A
What is the new behavior?
-margin
will always go with+dimmer
. On "tablet" view, it will display as-margin +dimmer
(same as "mobile" view).How to use?
N/A