Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize language selector #52

Merged
merged 4 commits into from
Jul 15, 2020
Merged

Conversation

iamapig120
Copy link
Contributor

PR Checklist

  • The commit message follows guidelines for NexT.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build & CI related changes.
  • Documentation.
  • Translation.
  • Other... Please describe:

What is the current behavior?

For example, if user changed title, added a lang selector to title section, the bottom one wont work.

Issue resolved: N/A

What is the new behavior?

If there are more than one language selectors, they will all work.

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

language_switcher: true

@welcome
Copy link

welcome bot commented Jul 14, 2020

Thanks so much for opening your first PR here!

Copy link
Member

@stevenjoezhang stevenjoezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@stevenjoezhang stevenjoezhang added this to the 8.0.0-rc.5 milestone Jul 15, 2020
@stevenjoezhang stevenjoezhang merged commit c485d9d into next-theme:master Jul 15, 2020
@welcome
Copy link

welcome bot commented Jul 15, 2020

Congrats on merging your first pull request here! 🎉 How awesome!

lingyf pushed a commit to lingyf/hexo-theme-next that referenced this pull request Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants