Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Comment): replace richEditor mixin with NcRichText #51239

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 4, 2025

  • Resolves: get rid of richEditor mixin direct usage, so it can be removed from lib or reworked
  • Based on the solution Talk uses

Summary

Before After
image image
image image

TODO

  • comments endpoint returns message as hi @alice @bob@nextcloud.com, NcRichText requires hi {mention-1} {mention-2} to be fed, as it can't parse some characters to mentions
  • activity app endpoint returns message_rich, which might be used, but current solution is compatible with and without activity app
  • markdown is supported by NcRichText, but not enabled to reduce changes

Checklist

@Antreesy Antreesy added this to the Nextcloud 32 milestone Mar 4, 2025
@Antreesy Antreesy requested a review from ShGKme March 4, 2025 18:13
@Antreesy Antreesy self-assigned this Mar 4, 2025
@Antreesy Antreesy requested a review from a team as a code owner March 4, 2025 18:13
@Antreesy Antreesy requested review from susnux, artonge and skjnldsv and removed request for a team March 4, 2025 18:13
@Antreesy

This comment was marked as outdated.

@nextcloud-command nextcloud-command requested a review from a team as a code owner March 4, 2025 18:19
@nextcloud-command nextcloud-command requested review from ArtificialOwl and removed request for a team March 4, 2025 18:19
@susnux

This comment was marked as resolved.

Verified

This commit was signed with the committer’s verified signature.
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/rich-editor-mixin branch from cfac405 to 1cc7a46 Compare March 5, 2025 08:12
@Antreesy
Copy link
Contributor Author

Antreesy commented Mar 5, 2025

/compile /

Verified

This commit was signed with the committer’s verified signature.
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Antreesy Antreesy merged commit a9aae84 into master Mar 5, 2025
121 checks passed
@Antreesy Antreesy deleted the fix/noid/rich-editor-mixin branch March 5, 2025 09:04
@Antreesy
Copy link
Contributor Author

Antreesy commented Mar 5, 2025

/backport to stable31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants