Add command to list orphan objects #51603
Merged
+370
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
skjnldsv,
Pytal,
ArtificialOwl,
come-nc,
artonge,
szaimen,
susnux,
nfebe and
a team
as code owners
icewind1991
force-pushed
the
object-store-orphan
branch
2 times, most recently
from
c3ed005 to
18e9980
Compare
come-nc
reviewed
Mar 24, 2025
| use Symfony\Component\Console\Output\OutputInterface; | ||
|
|
||
| class ObjectUtil { | ||
| class ObjectUtil extends Base { |
There was a problem hiding this comment.
Why is that needed?
It’s really weird for this helper that’s not a command or a command parent to extend Base.
There was a problem hiding this comment.
It's to get access to the output helpers
There was a problem hiding this comment.
I still don’t like it. It should either be a parent class to the commands, or a trait that they use.
There was a problem hiding this comment.
Moved the streaming output logic to Base so it no longer needs to inherit here
icewind1991
force-pushed
the
object-store-orphan
branch
from
89a4b67 to
a157ba7
Compare
1 task
come-nc
approved these changes
Mar 31, 2025
susnux
approved these changes
Mar 31, 2025
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
object-store-orphan
branch
from
a91f313 to
7ce06f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following commands:
occ files:object:info <object id>get metadata from an objectocc files:object:listlist all objectsocc files:object:orphanslist all objects not referenced in the databaseOnly implemented for S3 at the moment