Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logo generation is inconsistent between github actions runners and local execution #2893

Closed
jmuhlich opened this issue Mar 21, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jmuhlich
Copy link
Member

Description of the bug

nf-core lint run locally tells me my logo images don't match the template, but the GitHub Actions lint check passes. If I run nf-core lint --fix locally and commit the changes to the logos, the GHA lint check then fails. I examined the difference in the images and it looks like a minor text tracking/kerning issue. The two images and an image diff are attached below. The pipeline I'm working in is https://github.com/nf-core/mcmicro/ .

Image that passes GHA checks:
gha

Image generated by --fix locally:
local

Difference:
image

Command used and terminal output

No response

System information

tools 2.13.1

@mirpedrol
Copy link
Member

mirpedrol commented May 9, 2024

As of the new version of tools 2.14.0, nf-core lint is more permissive when comparing the logos, to allow for these small inconsistencies.
I am going to close this issue now, but feel free to reopen it if the errors appear again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants