Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GrpcChannelPool should configure unlimited max message size #885

Closed
bkeryan opened this issue Sep 13, 2024 · 0 comments · Fixed by #887
Closed

GrpcChannelPool should configure unlimited max message size #885

bkeryan opened this issue Sep 13, 2024 · 0 comments · Fixed by #887
Assignees
Labels
enhancement New feature or request triage New issue that needs to be reviewed

Comments

@bkeryan
Copy link
Collaborator

bkeryan commented Sep 13, 2024

Problem to Solve

The ability to send/receive large messages is important for both measurement clients and driver API clients.

By default, gRPC C Core has an unlimited max send message size and max receive message size of 4 MB:
https://github.com/grpc/grpc/blob/master/include/grpc/impl/grpc_types.h#L177

ni_measurement_plugin_sdk_service configures unlimited max send/receive message size for measurement services, but it doesn't do the same thing for clients.

Proposed Solution

Update GrpcChannelPool to configure unlimited max send/receive message size like the C# version of this class does.

The grpc_channel test fixture demonstrates how to do this:
https://github.com/ni/measurement-plugin-python/blob/main/packages/service/tests/conftest.py#L38

AB#2857146

@bkeryan bkeryan added enhancement New feature or request triage New issue that needs to be reviewed labels Sep 13, 2024
@bkeryan bkeryan linked a pull request Sep 16, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage New issue that needs to be reviewed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants