Update default channel pool options when creating grpc channels #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnel and will bypass proxies when target address is on the localhost.
jasonmreding
requested review from
csjall,
dixonjoel,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
bkeryan
requested changes
Sep 16, 2024
packages/service/ni_measurement_plugin_sdk_service/grpc/channelpool.py
Outdated
Show resolved
Hide resolved
packages/service/tests/unit/grpc/channelpool/test_channel_pool.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/grpc/channelpool.py
Outdated
Show resolved
Hide resolved
bkeryan
reviewed
Sep 16, 2024
packages/service/tests/unit/grpc/channelpool/test_channel_pool.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/grpc/channelpool.py
Outdated
Show resolved
Hide resolved
bkeryan
approved these changes
Sep 16, 2024
dixonjoel
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Updates the channel pool so that by default it:
Why should this Pull Request be merged?
This minimizes support issues with http proxies that are often difficult to diagnose.
What testing has been done?
http_proxyenvironment variable set before and after this change. I validated that example measurements fail to start successfully before the change (can't connect to discovery when trying to register themselves), and they start successfully after this change.