Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the TestStand sequence of measurement examples to make it simpler (DMM, FGEN, SCOPE, SWITCH, VISA DMM) #254

Merged
merged 8 commits into from
May 2, 2023

Conversation

vigkre
Copy link

@vigkre vigkre commented Apr 29, 2023

What does this Pull Request accomplish?

  • Updates the TestStand sequence in the example measurement to make it simpler by moving the process setup and process cleanup steps to the main sequence.
  • The sequence update and their relevant python functions are done for below examples:
    • DMM
    • FGEN
    • SCOPE
    • SWITCH
    • VISA DMM
  • Combines the logic for registering pin map into a single step in the Setup section. Previously this was handled in three steps.
  • Updated the Readme.md file for the updated examples.

Why should this Pull Request be merged?

Based on the feedback discussed in this Teams post, moving the process setup and process cleanup steps to the main sequence will simplify the example sequence as the user will only need to run the main sequence to get the expected result. Though this sequence is not efficient for multi-site use case, this change is encouraged as the example sequence is expected to be tailored to users who are beginners in TestStand.

What testing has been done?

  • Manually executed the TestStand example sequence with a simulated instrument and verified the result for below examples
    • DMM
    • FGEN
    • SCOPE
    • SWITCH
    • VISA DMM

@vigkre vigkre requested a review from Tharun-Sundar April 29, 2023 14:48
@vigkre vigkre changed the title Updated the TestStand sequence of measurement examples to make it simpler Updated the TestStand sequence of measurement examples to make it simpler (DMM, FGEN, SCOPE, SWITCH) Apr 29, 2023
Vikram Avudaiappan added 3 commits April 29, 2023 20:26
@vigkre vigkre force-pushed the users/vikram/simplify-teststand-example branch from 4da4c4c to ce5bb7b Compare April 29, 2023 14:57
@vigkre vigkre changed the title Updated the TestStand sequence of measurement examples to make it simpler (DMM, FGEN, SCOPE, SWITCH) Updated the TestStand sequence of measurement examples to make it simpler (DMM, FGEN, SCOPE, SWITCH, VISA DMM) May 1, 2023
Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vigkre vigkre merged commit e7f870f into main May 2, 2023
vigkre pushed a commit that referenced this pull request May 4, 2023
…pler (DMM, FGEN, SCOPE, SWITCH, VISA DMM) (#254)

* examples: Updated the TestStand sequence of measurement to simplify the pin map and session registration steps for measurements similar to DC Power

* examples: Update ReadMe to mention that the sequence file is not efficient for batch process

* examples: Fix lint errors

* examples: Delete duplicate expression steps, delete PinMapFileName, updated PinMapPath to relative file path

* examples: Update TestStand sequence for VISA DMM and related function

* examples: Fix lint error for VISA DMM Fixtures

* examples: Update Readme to include TestStand sequence simplification for VISA DMM

* examples: Readme for test stand seq update is word wrapped
@dixonjoel dixonjoel deleted the users/vikram/simplify-teststand-example branch September 15, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants