-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the TestStand sequence of measurement examples to make it simpler (DMM, FGEN, SCOPE, SWITCH, VISA DMM) #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he pin map and session registration steps for measurements similar to DC Power
…cient for batch process
4da4c4c
to
ce5bb7b
Compare
bkeryan
requested changes
Apr 30, 2023
1 task
bkeryan
approved these changes
May 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
dixonjoel
approved these changes
May 1, 2023
bkeryan
reviewed
May 1, 2023
vigkre
pushed a commit
that referenced
this pull request
May 4, 2023
…pler (DMM, FGEN, SCOPE, SWITCH, VISA DMM) (#254) * examples: Updated the TestStand sequence of measurement to simplify the pin map and session registration steps for measurements similar to DC Power * examples: Update ReadMe to mention that the sequence file is not efficient for batch process * examples: Fix lint errors * examples: Delete duplicate expression steps, delete PinMapFileName, updated PinMapPath to relative file path * examples: Update TestStand sequence for VISA DMM and related function * examples: Fix lint error for VISA DMM Fixtures * examples: Update Readme to include TestStand sequence simplification for VISA DMM * examples: Readme for test stand seq update is word wrapped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Readme.md
file for the updated examples.Why should this Pull Request be merged?
Based on the feedback discussed in this Teams post, moving the process setup and process cleanup steps to the main sequence will simplify the example sequence as the user will only need to run the main sequence to get the expected result. Though this sequence is not efficient for multi-site use case, this change is encouraged as the example sequence is expected to be tailored to users who are beginners in TestStand.
What testing has been done?