[BUG2433073] Added Enum out to sample_measurement
#307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pes for v2 measurement services.
… getting annotations for output parameters.
…turns_metadata where it was checking if message types were v1 rather than v2.
WesleyTangNationalInstruments
requested review from
csjall,
pbirkhol-ni,
dixonjoel,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
dixonjoel
approved these changes
Jun 27, 2023
|
If you want this to be in the release associated with 23Q3, you'll want to cherry pick to the releases/1.1 branch. |
bkeryan
approved these changes
Jun 27, 2023
…pleMeasurementMissingEnumOutput # Conflicts: # examples/sample_measurement/SampleMeasurement.serviceconfig
WesleyTangNationalInstruments
added a commit
that referenced
this pull request
Jun 27, 2023
* Fixed an issue in the servicer where we were not adding annotations to output. * Fixed an issue in the servicer where we were specifying v1 message types for v2 measurement services. * Fixed an issue where sample files was using v1 interface and thus not getting annotations for output parameters. * Updated measui files for sample measurement to include enum out control. * Fixed an issue with test___measurement_service_v2___get_metadata___returns_metadata where it was checking if message types were v1 rather than v2.
WesleyTangNationalInstruments
deleted the
users/wetang/FixedSampleMeasurementMissingEnumOutput
branch
WesleyTangNationalInstruments
added a commit
that referenced
this pull request
Jun 27, 2023
* Fixed an issue in the servicer where we were not adding annotations to output. * Fixed an issue in the servicer where we were specifying v1 message types for v2 measurement services. * Fixed an issue where sample files was using v1 interface and thus not getting annotations for output parameters. * Updated measui files for sample measurement to include enum out control. * Fixed an issue with test___measurement_service_v2___get_metadata___returns_metadata where it was checking if message types were v1 rather than v2.
Merged
1 task
WesleyTangNationalInstruments
added a commit
that referenced
this pull request
Jun 27, 2023
…nt) to releases/1.1 (#309) [BUG2433073] Added `Enum out` to sample_measurement (#307) * Fixed an issue in the servicer where we were not adding annotations to output. * Fixed an issue in the servicer where we were specifying v1 message types for v2 measurement services. * Fixed an issue where sample files was using v1 interface and thus not getting annotations for output parameters. * Updated measui files for sample measurement to include enum out control. * Fixed an issue with test___measurement_service_v2___get_metadata___returns_metadata where it was checking if message types were v1 rather than v2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
test___measurement_service_v2___get_metadata___returns_metadatawhere it was checking for v1 message types.Why should this Pull Request be merged?
AB#2433073
AB#2429625
What testing has been done?