-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
discovery_client: When a python measurement starts discovery service, hide discovery service logs #343
Merged
vigkre
merged 10 commits into
main
from
users/vikram/hide-discovery-service-console-logs
Jul 31, 2023
Merged
discovery_client: When a python measurement starts discovery service, hide discovery service logs #343
vigkre
merged 10 commits into
main
from
users/vikram/hide-discovery-service-console-logs
Jul 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 12 files ±0 12 suites ±0 18m 17s ⏱️ + 1m 2s Results for commit 5f97556. ± Comparison against base commit dbbee49. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
mshafer-NI
reviewed
Jul 27, 2023
bkeryan
requested changes
Jul 27, 2023
bkeryan
requested changes
Jul 27, 2023
9a090b3
to
f280a25
Compare
bkeryan
reviewed
Jul 27, 2023
…if service is not registered with disc service
bkeryan
requested changes
Jul 27, 2023
bkeryan
approved these changes
Jul 27, 2023
samchris007
approved these changes
Jul 28, 2023
dixonjoel
approved these changes
Jul 28, 2023
Tharun-Sundar
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
FileNotFoundError
when wrong discovery service .exe path is specified for subprocess.popen function.FileNotFoundError
exception.Why should this Pull Request be merged?
What testing has been done?
- Specified wrong discovery service .exe path to
subprocess.popen
function and noticed the log error is captured in the console: