discovery_client: Fix auto-launching discovery service producing a ResourceWarning #344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
subprocess.popen
object to a global variable.subprocess
which in turn denotes that the subprocess is still running and produces aResourceWarning
.Why should this Pull Request be merged?
subprocess.Popen
, which produces aResourceWarning
.What testing has been done?
poetry run python measurement.py -v
.ResourceWarning
doesn't happen anymore.poetry run python -X dev measurement.py
to reproduce theResourceWarning
.