Read serviceconfig path from __file__ or exe location and update README. #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…env, and the requirement to include .serviceconfig file. Signed-off-by: Chris Delpire <chris.delpire@ni.com>
DelpireNI
requested review from
csjall,
pbirkhol-ni,
dixonjoel,
bkeryan and
nstokes-nati
as code owners
|
Moving to draft. My suggestion to include the |
bkeryan
requested changes
Aug 16, 2023
bkeryan
reviewed
Aug 16, 2023
…bute exists. Signed-off-by: Chris Delpire <chris.delpire@ni.com>
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
DelpireNI
changed the title
bkeryan
requested changes
Aug 22, 2023
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
|
Reminder - run 'poetry run pytest' locally. The state we're in right now before we add a self-hosted test runner is that there are a number of tests that are skipped on the PR checks. |
dixonjoel
approved these changes
Aug 23, 2023
Tests passed. |
bkeryan
approved these changes
Aug 24, 2023
DelpireNI
deleted the
users/cdelpire/update-readme-to-improve-create-executable-for-python-scripts-section
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Updating how we are loading serviceconfig and other files. If we are running as an exe, we will look next to the exe, otherwise we will look next to
__file__Why should this Pull Request be merged?
People building exe's have run into issues referencing their serviceconfig and UI files. The recommendation for UI files was to include it in the exe using
--add-path. I was going to recommend this for serviceconfig files as well, but realized this would effectively dual source the serviceconfig as the DiscoveryService expects a copy on disk.What testing has been done?
Tested running example as both a script and as an exe.