Importing nidcpower.session into output voltage measurement #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ample. Signed-off-by: Chris Delpire <chris.delpire@ni.com>
DelpireNI
requested review from
csjall,
pbirkhol-ni,
dixonjoel,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
|
I don't know what caused this. I filed a bug about the fact that this public API returns an internal type: ni/nimi-python#2019 |
bkeryan
requested changes
Sep 22, 2023
DelpireNI
changed the title
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
DelpireNI
changed the title
bkeryan
approved these changes
Sep 22, 2023
DelpireNI
deleted the
users/cdelpire/fix-output-voltage-measurement-example
branch
DelpireNI
added a commit
that referenced
this pull request
Sep 25, 2023
* Replacing _SessionBase with Session in Output Voltaget Measurement example. Signed-off-by: Chris Delpire <chris.delpire@ni.com> * Switching back to _SessionBase and adding import statement to fix issue. * importing nidcpower.session and fixing type hint. Signed-off-by: Chris Delpire <chris.delpire@ni.com> --------- Signed-off-by: Chris Delpire <chris.delpire@ni.com>
1 task
DelpireNI
added a commit
that referenced
this pull request
Sep 25, 2023
…ement (#399) (#406) Importing nidcpower.session into output voltage measurement (#399) * Replacing _SessionBase with Session in Output Voltaget Measurement example. * Switching back to _SessionBase and adding import statement to fix issue. * importing nidcpower.session and fixing type hint. --------- Signed-off-by: Chris Delpire <chris.delpire@ni.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
When running the OutputVoltageMeasurement I got the following error:
I am not sure what has happened withnidcpower._SessionBase. A search in the ni/nimi-python repo shows this class for our other drivers, DMM, Scope, Switch, etc., but I do not see it for nidcpower.Importing nidcpower.session and fixing type hint.
Why should this Pull Request be merged?
Currently it seems the measurement cannot be run out of the box. This should fix it.
What testing has been done?
Was able to run the measurement successfully and it worked with both InstrumentStudio and TestStand.