service: Update reserve_session to roll back on error #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeryan
requested review from
csjall,
pbirkhol-ni,
dixonjoel,
mshafer-NI and
nstokes-nati
as code owners
jonathanmendez
approved these changes
Sep 22, 2023
1 task
DelpireNI
approved these changes
Sep 22, 2023
dixonjoel
approved these changes
Sep 22, 2023
bkeryan
added a commit
that referenced
this pull request
Sep 25, 2023
(cherry picked from commit 761140f)
1 task
bkeryan
added a commit
that referenced
this pull request
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Update
SessionManagementClient.reserve_sessionto roll back the reservation when raising a "Too many sessions reserved" error.I don't think it's necessary to roll back the "No sessions reserved" case because the session management server's unreserve method would loop over an empty list.
Why should this Pull Request be merged?
Fixes #400
What testing has been done?
Ran new acceptance test (part of separate PR)