-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing some cosmetic issues with the output voltage measurement examp… #424
Fixing some cosmetic issues with the output voltage measurement examp… #424
Conversation
…le measui. Signed-off-by: Chris Delpire <chris.delpire@ni.com>
Other examples move |
It feels like there is too much margin at the top. I left it close to the existing UI's margin, but I'm happy to shift things up if others agree. |
I agree, the top/bottom margins are inconsistent and too big. Also, the grey boxes have inconsistent left/bottom/right margins. (I'm ignoring top because of the label.) Also the spacing between columns. |
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
Okay I have made the margins more consistent and reduced the height. |
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
…le measui.
What does this Pull Request accomplish?
Updated the measui for the Output Voltage Measurement example to fix cosmetic issues. We should now be more consistent with the other examples' UIs.
The Input and Output pin controls are now outside the grey boxes, and at the top like other examples.
The labels over the grey boxes have been renamed to Source configuration and Measurement configuration.
Why should this Pull Request be merged?
Consistency with other examples.
(#412)
What testing has been done?
Example still runs. This is just a cosmetic change.