Add support for Python 3.12 #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeryan
requested review from
csjall,
pbirkhol-ni and
dixonjoel
as code owners
DelpireNI
approved these changes
Oct 3, 2023
pbirkhol-ni
reviewed
Oct 5, 2023
pbirkhol-ni
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Update
pyproject.tomlto specify a newer version ofgrpcio-toolswhen using Python 3.12. Continue using the oldergrpcio-toolswith older Python versions to avoid any changes to codegen.Enable Python 3.12 in PR run-tests workflow.
Why should this Pull Request be merged?
Test with the latest released Python.
What testing has been done?
Ran
poetry run pytest -von a machine with MeasurementLink and Python 3.12 installed. Warnings: #428Manually tested
nidcpower_source_dc_voltagein InstrumentStudio with Python 3.12.Was unable to load TestStand code modules with Python 3.12 in TestStand 2021 SP1.