Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR2] Split the TestStand modules into specific modules for the niscope, nifgen and nidmm examples #461

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

samchris007
Copy link
Contributor

What does this Pull Request accomplish?

Split TestStand code modules in the examples by pinmap-specific and driver-specific logic and updated the TestStand sequences accordingly.

The nidmm_measurement, nifgen_standard_function, and niscope_acquire_waveform examples' TestStand code modules are split into driver-specific and pin map-specific code.

Why should this Pull Request be merged?

Implements #392 for nidmm_measurement, nifgen_standard_function, and niscope_acquire_waveform examples

What testing has been done?

  • Manually tested by running the sequence examples
  • Ran the existing tests.

@samchris007 samchris007 changed the title [PR2] Split the TestStand modules into specific modules for pinmap and driver specific logic [PR2] Split the TestStand modules into specific modules for the niscope, nifgen and niscope examples Oct 17, 2023
@samchris007 samchris007 changed the title [PR2] Split the TestStand modules into specific modules for the niscope, nifgen and niscope examples [PR2] Split the TestStand modules into specific modules for the niscope, nifgen and nidmm examples Oct 17, 2023
@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Test Results

       30 files  ±0       30 suites  ±0   24m 9s ⏱️ - 1m 54s
     452 tests ±0     376 ✔️ ±0       76 💤 ±0  0 ±0 
13 530 runs  ±0  9 650 ✔️ ±0  3 880 💤 ±0  0 ±0 

Results for commit 301d946. ± Comparison against base commit 056b3ca.

♻️ This comment has been updated with latest results.

@samchris007 samchris007 marked this pull request as ready for review October 18, 2023 12:40
@samchris007 samchris007 requested a review from bkeryan October 19, 2023 07:14
@dixonjoel dixonjoel merged commit 6e18fc3 into main Oct 19, 2023
@dixonjoel dixonjoel deleted the users/sam/split-tsmodule-dmm,fgen,scope branch October 19, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants