[PR1] Move .env.simulation to .env in run_system_tests workflow #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MounikaBattu17
requested review from
csjall,
pbirkhol-ni,
dixonjoel,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
1 task
keer1111
approved these changes
Nov 2, 2023
MounikaBattu17
commented
Nov 2, 2023
MounikaBattu17
changed the title
vigkre
approved these changes
Nov 2, 2023
1 task
MounikaBattu17
changed the title
|
Now, we see that having cc: @bkeryan @dixonjoel |
dixonjoel
approved these changes
Nov 2, 2023
bkeryan
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
.envfile in root directory to simulate driver instruments, so movedexamples/.env.simulationto.envin pipeline such that it runs acceptance tests without any errors..envoverrides the session parameter default values in unit tests that doesn't use simulation mode, which fails the tests. So to resolve this issue, passed in the default values when calling initialize session in unit tests.Why should this Pull Request be merged?
To run acceptance tests that uses simulated instrument drivers in pipeline.
What testing has been done?
Manually ran
poetry run pytest.