tests: Add integration and acceptance tests for NI-DMM and NI-DAQmx drivers session management APIs #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avinash2Suresh
requested review from
csjall,
pbirkhol-ni,
dixonjoel,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
vigkre
reviewed
Nov 6, 2023
vigkre
reviewed
Nov 6, 2023
vigkre
reviewed
Nov 6, 2023
tests/integration/session_management/test_nidaqmx_reservation.py
Outdated
Show resolved
Hide resolved
vigkre
reviewed
Nov 6, 2023
tests/integration/session_management/test_nidaqmx_reservation.py
Outdated
Show resolved
Hide resolved
vigkre
suggested changes
Nov 6, 2023
Avinash2Suresh
changed the title
Avinash2Suresh
changed the title
bkeryan
requested changes
Nov 7, 2023
tests/assets/acceptance/session_management/1Daqmx2ChannelGroup2Pin1Site.pinmap
Outdated
Show resolved
Hide resolved
tests/assets/acceptance/session_management/1Daqmx2ChannelGroup2Pin1Site.pinmap
Outdated
Show resolved
Hide resolved
bkeryan
reviewed
Nov 7, 2023
Avinash2Suresh
force-pushed
the
users/avinash/dmm-daqmx-tests
branch
from
6408faf to
07320b9
Compare
dixonjoel
approved these changes
Nov 7, 2023
bkeryan
requested changes
Nov 7, 2023
bkeryan
reviewed
Nov 7, 2023
Avinash2Suresh
force-pushed
the
users/avinash/dmm-daqmx-tests
branch
from
4de2104 to
94addab
Compare
Avinash2Suresh
changed the title
jayaseelan-james
changed the title
vigkre
approved these changes
Nov 8, 2023
bkeryan
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
nidmm_measurement.pyandnidaqmx_measurement.pytest service modules and adds integration and acceptance tests for nidmm and nidaqmx driver-specific session management APIs.create_nidaqmx_tasksfromnidcpower.Sessiontonidaqmx.Tasksince it was previously returning the wrong type."Why should this Pull Request be merged?
To add "nidmm" and "nidaqmx" driver-specific tests to the repository. #AB2564984
What testing has been done?
Ran mypy and pytest.