Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused methods in _helpers.py.mako and update its copies under examples #510

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Remove unused methods in _helpers.py.mako and update its copies under examples #510

merged 2 commits into from
Nov 9, 2023

Conversation

Avinash2Suresh
Copy link
Contributor

@Avinash2Suresh Avinash2Suresh commented Nov 8, 2023 •
edited by jayaseelan-james
Loading

What does this Pull Request accomplish?

  • Removes unused command line arguments and other methods in the measurement generator template and updates the helpers.py copies under each existing example.

Why should this Pull Request be merged?

Remove the command line arguments from the _helpers.py module, that aren't used. #AB2552336

What testing has been done?

  • Manually tested the NI-DCPower example.
  • Ran ni_measurementlink_generator tests.
  • Ran mypy for each of the examples.
  • Generated and verified the changes in the measurement service.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023 •
edited
Loading

Test Results

       30 files  ±0         30 suites  ±0   36m 24s ⏱️ - 3m 12s
     491 tests ±0       491 ✔️ ±0         0 💤 ±0  0 ❌ ±0 
12 510 runs  ±0  11 450 ✔️ ±0  1 060 💤 ±0  0 ❌ ±0 

Results for commit 58bb909. ± Comparison against base commit 43249a5.

♻️ This comment has been updated with latest results.

@jayaseelan-james jayaseelan-james changed the title Refactor helper functions to remove command line arguments Remove unused methods in _helpers.py.mako and update its copies under examples Nov 8, 2023
@bkeryan bkeryan merged commit 33d97d4 into main Nov 9, 2023
@bkeryan bkeryan deleted the users/avinash/remove-from-helpers branch November 9, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkeryan bkeryan bkeryan approved these changes

@jayaseelan-james jayaseelan-james jayaseelan-james left review comments

@vigkre vigkre vigkre approved these changes

@dixonjoel dixonjoel dixonjoel approved these changes

@keer1111 keer1111 keer1111 approved these changes

@csjall csjall Awaiting requested review from csjall csjall is a code owner

@pbirkhol-ni pbirkhol-ni Awaiting requested review from pbirkhol-ni

@mshafer-NI mshafer-NI Awaiting requested review from mshafer-NI mshafer-NI is a code owner

@nstokes-nati nstokes-nati Awaiting requested review from nstokes-nati nstokes-nati is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Avinash2Suresh @vigkre @bkeryan @dixonjoel @keer1111 @jayaseelan-james