examples: Add gRPC support to VISA examples #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeryan
requested review from
csjall,
pbirkhol-ni,
dixonjoel,
mshafer-NI and
nstokes-nati
as code owners
dixonjoel
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Update
nivisa_dmm_measurementandoutput_voltage_measurementto use NI gRPC Device Server._visa_dmm_session_management.py,_visa_grpc.py, andteststand_visa_dmm.pyare duplicated or "vendored" in each example.I would like to move some of the VISA session management code into
ni-measurementlink-service(#522 is intended to move in that direction), but for now I'm adding it as example code.Why should this Pull Request be merged?
Allow sharing VISA sessions between multiple measurement services.
What testing has been done?
nivisa_dmm_measurementwith a physical HP 34401A, simulation, and various permutations ofUSE_GRPC_DEVICE_SERVERandGRPC_DEVICE_SERVER_ADDRESS.output_voltage_measurementwith physical NI PXIe-4141 and HP 34401A instruments.